Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various things to try to improve TTFX #138

Merged
merged 3 commits into from
Oct 29, 2023
Merged

various things to try to improve TTFX #138

merged 3 commits into from
Oct 29, 2023

Conversation

alecloudenback
Copy link
Member

@alecloudenback alecloudenback commented Aug 27, 2022 •
edited
Loading 

julia> @time using FinanceModels
[ Info: Precompiling FinanceModels [77f2ae65-bdde-421f-ae9d-22f1af19dd76]
 19.078215 seconds (16.57 M allocations: 1.238 GiB, 1.16% gc time, 8.20% compilation time: 91% of which was recompilation)

julia> @time using FinanceModels
  6.228624 seconds (16.39 M allocations: 1.227 GiB, 3.95% gc time, 22.51% compilation time: 92% of which was recompilation)

After:

julia> @time using FinanceModels
[ Info: Precompiling FinanceModels [77f2ae65-bdde-421f-ae9d-22f1af19dd76]
 15.961583 seconds (15.75 M allocations: 1.190 GiB, 1.42% gc time, 9.68% compilation time: 90% of which was recompilation)

julia> @time using FinanceModels
  5.865737 seconds (15.56 M allocations: 1.177 GiB, 3.94% gc time, 23.81% compilation time: 91% of which was recompilation)

@JuliaActuary JuliaActuary deleted a comment from codecov bot Oct 29, 2023
@codecov
Copy link

codecov bot commented Oct 29, 2023 •
edited
Loading

Codecov Report

Merging #138 (a949f9b) into master (36cbcf3) will not change coverage.
The diff coverage is 66.66%.

❗ Current head a949f9b differs from pull request most recent head 167e17e. Consider uploading reports for the commit 167e17e to get more accurate results

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   86.04%   86.04%           
=======================================
  Files          13       13           
  Lines         344      344           
=======================================
  Hits          296      296           
  Misses         48       48
Files Coverage Δ
src/FinanceModels.jl 100.00% <ø> (ø)
src/model/Yield.jl 96.90% <ø> (ø)
src/utils.jl 11.76% <66.66%> (+11.76%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alecloudenback alecloudenback merged commit abd10b4 into master Oct 29, 2023
22 of 23 checks passed
@alecloudenback alecloudenback deleted the TTFX branch October 29, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alecloudenback